This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Perf test framework
- From: Yao Qi <yao at codesourcery dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 6 Nov 2013 13:22:12 +0800
- Subject: Re: [PATCH 2/4] Perf test framework
- Authentication-results: sourceware.org; auth=none
- References: <1383291300-13917-1-git-send-email-yao at codesourcery dot com> <1383291300-13917-3-git-send-email-yao at codesourcery dot com> <877gcryhnz dot fsf at fleche dot redhat dot com> <52746636 dot 8080102 at codesourcery dot com> <87sivcuoch dot fsf at fleche dot redhat dot com>
On 11/05/2013 12:24 AM, Tom Tromey wrote:
Yao> + if { "$GDB_PERFTEST_MODE" != "compile"
Yao> + && "$GDB_PERFTEST_MODE" != "run"
Yao> + && "$GDB_PERFTEST_MODE" != "both" } {
Yao> + # GDB_PERFTEST_MODE=compile|run|both is allowed.
Yao> + unsupported "Unknown value of GDB_PERFTEST_MODE."
Yao> + return 1
This is basically an internal error.
Calling "error" and having a backtrace in the log seems better to me.
Fixed it in the commit. Thanks for the review.
--
Yao (éå)