This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] Fix python/14513
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 30 Oct 2013 09:00:55 +0000
- Subject: Re: [patch][python] Fix python/14513
- Authentication-results: sourceware.org; auth=none
- References: <5239A7E9 dot 8010202 at redhat dot com> <877gedub9p dot fsf at fleche dot redhat dot com> <523A0E4E dot 3090105 at redhat dot com> <8738p1uam6 dot fsf at fleche dot redhat dot com> <524BE7B3 dot 3030805 at redhat dot com> <87mwm2i8vi dot fsf at fleche dot redhat dot com>
On 21/10/13 22:58, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> I am not sure what the resolution is here. At some point we have to
> Phil> decide whether we have anything valid to print. We can hoist the
> Phil> fprint into both of these branches, but even in the "else" clause we
> Phil> have to check if we actually have anything as the fprint adds a
> Phil> newline to the set documentation:
>
> Phil> fprintf_filtered (gdb_stdout, "%s\n", set_doc_string);
>
> Phil> What are your thoughts on this?
>
> I've been thinking about it more and I don't understand why we want to
> print anything in the "set" command.
> I think it's fine if we just don't call a method.
> What do you think of that?
I am fine with it, as long as you are.
Cheers,
Phil