This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table
- From: Tom Tromey <tromey at redhat dot com>
- To: hex <heixia108 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 29 Oct 2013 12:34:01 -0600
- Subject: Re: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table
- Authentication-results: sourceware.org; auth=none
- References: <CAB_AMN4CyoKKjd=_51d+a25HPnj=TK5aQTxGH321tkjtjOyg5Q at mail dot gmail dot com> <874n869zs9 dot fsf at fleche dot redhat dot com> <CAB_AMN7ZyhaNKZsn3WLZmRyHe4SBxMsMbuXEdmMkvGhiXdnwcw at mail dot gmail dot com>
>>>>> ">" == hex <heixia108@gmail.com> writes:
>> Thank you for the review. I have attached the test case.
The test case needs a ChangeLog entry.
I'd much prefer a test using the DWARF assembler than one using actual
assembly code. There are other examples in gdb.dwarf2. The reason to
prefer the DWARF assembler is that it is more portable.
>> # You should have received a copy of the GNU General Public License
>> # along with this program. If not, see <http://www.gnu.org/licenses/>.
>> load_lib dwarf.exp
A blank line between the comments and the first line of code, please.
>> # Test DW_OP_stack_value and DW_OP_implicit_value.
This comment seems incorrect.
Tom