This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Extra error message from update_watchpoint
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Andrew Burgess <aburgess at broadcom dot com>
- Cc: gdb-patches at sourceware dot org, palves at redhat dot com
- Date: Tue, 29 Oct 2013 19:19:52 +0200
- Subject: Re: [PATCH] Extra error message from update_watchpoint
- Authentication-results: sourceware.org; auth=none
- References: <5260FD66 dot 7090506 at broadcom dot com> <52616D4B dot 3020209 at redhat dot com> <526FE5E9 dot 3000909 at broadcom dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Tue, 29 Oct 2013 16:44:25 +0000
> From: "Andrew Burgess" <aburgess@broadcom.com>
> cc: "Pedro Alves" <palves@redhat.com>
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 608463d..68b348d 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -1805,7 +1805,8 @@ update_watchpoint (struct watchpoint *b, int reparse)
> if (b->base.ops->works_in_software_mode (&b->base))
> b->base.type = bp_watchpoint;
> else
> - error (_("Software read/access watchpoints not supported."));
> + error (_("Hardware watchpoint support disabled. "
> + "See set/show can-use-hw-watchpoints."));
Sorry for chiming in late, but IMO this change is a step backwards:
the new warning is much more puzzling than the old one. The old one
at least told what was the problem, the new one looks like entirely
unrelated (unless you are privy to GDB internals).
How about something like
Cannot set read/access watchpoints without hardware watchpoint support.