This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 1/9] fix latent bugs in ui-out.c
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 28 Oct 2013 15:20:17 +0000
- Subject: Re: [PATCH v4 1/9] fix latent bugs in ui-out.c
- Authentication-results: sourceware.org; auth=none
- References: <1382464769-2465-1-git-send-email-tromey at redhat dot com> <1382464769-2465-2-git-send-email-tromey at redhat dot com>
On 10/22/2013 06:59 PM, Tom Tromey wrote:
> The destructor code in ui-out.c has a latent bug, which is hidden by
> the fact that nothing uses this right now. This patch fixes the
> problem. The bug is that we don't always clear a pointer in the
> ui-out object, leading to bad a free.
"to a bad free"
>
> * ui-out.c (clear_table, ui_out_new): Clear uiout->table.id.
Looks good to me.
--
Pedro Alves