This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4 1/9] fix latent bugs in ui-out.c


On 10/22/2013 06:59 PM, Tom Tromey wrote:
> The destructor code in ui-out.c has a latent bug, which is hidden by
> the fact that nothing uses this right now.  This patch fixes the
> problem.  The bug is that we don't always clear a pointer in the
> ui-out object, leading to bad a free.

"to a bad free"

> 
> 	* ui-out.c (clear_table, ui_out_new): Clear uiout->table.id.

Looks good to me.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]