This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 07/17] fix up gdb.trace


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 10/18/2013 09:49 PM, Tom Tromey wrote:
>> +if {![is_remote host] && ![is_remote target]} {
>> +    set tfile_basic [standard_output_file tfile-basic.tf]
>> +    set tfile_dir [file dirname $tfile_basic]/
>> +    set purely_local 1
>> +} else {
>> +    set purely_local 0
>> +    set tfile_basic tfile-basic.tf
>> +    set tfile_dir ""
>> +}
>> +

Pedro> Minor, minor nit.  Can you define the variables in the same
Pedro> order in both branches?  My eyes crossed a little going back
Pedro> and forth comparing the values of both branches, for the
Pedro> branches not having the same pattern.  Sorry for the trouble.

It's no trouble.
I made the change locally.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]