This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 07/17] fix up gdb.trace
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 25 Oct 2013 10:37:18 -0600
- Subject: Re: [PATCH v2 07/17] fix up gdb.trace
- Authentication-results: sourceware.org; auth=none
- References: <1382129374-18344-1-git-send-email-tromey at redhat dot com> <1382129374-18344-8-git-send-email-tromey at redhat dot com> <526A9AB8 dot 1090500 at redhat dot com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 10/18/2013 09:49 PM, Tom Tromey wrote:
>> +if {![is_remote host] && ![is_remote target]} {
>> + set tfile_basic [standard_output_file tfile-basic.tf]
>> + set tfile_dir [file dirname $tfile_basic]/
>> + set purely_local 1
>> +} else {
>> + set purely_local 0
>> + set tfile_basic tfile-basic.tf
>> + set tfile_dir ""
>> +}
>> +
Pedro> Minor, minor nit. Can you define the variables in the same
Pedro> order in both branches? My eyes crossed a little going back
Pedro> and forth comparing the values of both branches, for the
Pedro> branches not having the same pattern. Sorry for the trouble.
It's no trouble.
I made the change locally.
Tom