This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 07/17] fix up gdb.trace
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 25 Oct 2013 17:22:16 +0100
- Subject: Re: [PATCH v2 07/17] fix up gdb.trace
- Authentication-results: sourceware.org; auth=none
- References: <1382129374-18344-1-git-send-email-tromey at redhat dot com> <1382129374-18344-8-git-send-email-tromey at redhat dot com>
On 10/18/2013 09:49 PM, Tom Tromey wrote:
> +if {![is_remote host] && ![is_remote target]} {
> + set tfile_basic [standard_output_file tfile-basic.tf]
> + set tfile_dir [file dirname $tfile_basic]/
> + set purely_local 1
> +} else {
> + set purely_local 0
> + set tfile_basic tfile-basic.tf
> + set tfile_dir ""
> +}
> +
Minor, minor nit. Can you define the variables in the same
order in both branches? My eyes crossed a little going back
and forth comparing the values of both branches, for the
branches not having the same pattern. Sorry for the trouble.
> +if {![is_remote host] && ![is_remote target]} {
> + set tfile_basic [standard_output_file tfile-basic.tf]
> + set tfile_error [standard_output_file tfile-error.tf]
> + set tfile_dir [file dirname $tfile_basic]/
> + set purely_local 1
> +} else {
> + set tfile_basic tfile-basic.tf
> + set tfile_error tfile-error.tf
> + set purely_local 0
> + set tfile_dir ""
> +}
> +
Here too, and also in tfile.exp.
--
Pedro Alves