This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/9] introduce minimal_symbol_upper_bound


>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> When I read the comment "Try ..." I'm left with asking "What if the
Doug> attempt fails?".
Doug> Maybe remove the words "Try to" and be clearer about what the result
Doug> is if a heuristic is needed?

I changed it to read:

/* Compute the upper bound of MINSYM.  The upper bound is the last
   address thought to be part of the symbol.  If the symbol has a
   size, it is used.  Otherwise use the lesser of the next minimal
   symbol in the same section, or the end of the section, as the end
   of the function.  */

Let me know what you think.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]