This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/9] introduce minimal_symbol_upper_bound


On Thu, Oct 17, 2013 at 10:49 AM, Tom Tromey <tromey@redhat.com> wrote:
> [...]
> diff --git a/gdb/minsyms.h b/gdb/minsyms.h
> index 95bbdc5..e1562d5 100644
> --- a/gdb/minsyms.h
> +++ b/gdb/minsyms.h
> @@ -249,4 +249,9 @@ void iterate_over_minimal_symbols (struct objfile *objf,
>                                                      void *),
>                                    void *user_data);
>
> +/* Try to compute the upper bound of MINSYM.  The upper bound is the
> +   last address thought to be part of the symbol.  */
> +
> +CORE_ADDR minimal_symbol_upper_bound (struct bound_minimal_symbol minsym);
> +
>  #endif /* MINSYMS_H */

When I read the comment "Try ..." I'm left with asking "What if the
attempt fails?".
Maybe remove the words "Try to" and be clearer about what the result
is if a heuristic is needed?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]