This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/9] introduce minimal_symbol_upper_bound
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 18 Oct 2013 15:01:01 -0700
- Subject: Re: [PATCH v2 1/9] introduce minimal_symbol_upper_bound
- Authentication-results: sourceware.org; auth=none
- References: <1382032193-9115-1-git-send-email-tromey at redhat dot com> <1382032193-9115-2-git-send-email-tromey at redhat dot com>
On Thu, Oct 17, 2013 at 10:49 AM, Tom Tromey <tromey@redhat.com> wrote:
> [...]
> diff --git a/gdb/minsyms.h b/gdb/minsyms.h
> index 95bbdc5..e1562d5 100644
> --- a/gdb/minsyms.h
> +++ b/gdb/minsyms.h
> @@ -249,4 +249,9 @@ void iterate_over_minimal_symbols (struct objfile *objf,
> void *),
> void *user_data);
>
> +/* Try to compute the upper bound of MINSYM. The upper bound is the
> + last address thought to be part of the symbol. */
> +
> +CORE_ADDR minimal_symbol_upper_bound (struct bound_minimal_symbol minsym);
> +
> #endif /* MINSYMS_H */
When I read the comment "Try ..." I'm left with asking "What if the
attempt fails?".
Maybe remove the words "Try to" and be clearer about what the result
is if a heuristic is needed?