This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]


On Thu, 17 Oct 2013 22:51:55 +0200, Tom Tromey wrote:
> >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
> 
> Keith> There are two little sections of code, though, which violate
> Keith> const-ness of the input, and I've removed those, since they don't
> Keith> seem necessary. [This is the two loops that deal with changing
> Keith> the case of `tokstart' -- which can easily be removed because we
> Keith> already have a temporary buffer that is used for this.]
> 
> I think it's somewhat wrong to do this stuff in the parser anyhow.
> Ideally the symbol table ought to know that pascal is case-insensitive.
> I think we faced this with Fortran as well.

Case insensitive symbols should be supported (originally written for Fortran)
since:
	commit 5b7743a275e4610fe6ea57f0c61e317490ee6854
	Date:   Wed Apr 27 20:03:03 2011 +0000
		Case insensitive lookups implementation.
(+about one fallout later)

While f_language_defn has case_sensitive_off
I see that pascal_language_defn has case_sensitive_on.

At https://en.wikipedia.org/wiki/Pascal_%28programming_language%29#Hello_world
I read
	Letter case is ignored in Pascal source.
so I think pascal_language_defn really should use case_sensitive_off.


Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]