This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> There are two little sections of code, though, which violate
Keith> const-ness of the input, and I've removed those, since they don't
Keith> seem necessary. [This is the two loops that deal with changing
Keith> the case of `tokstart' -- which can easily be removed because we
Keith> already have a temporary buffer that is used for this.]

I think it's somewhat wrong to do this stuff in the parser anyhow.
Ideally the symbol table ought to know that pascal is case-insensitive.
I think we faced this with Fortran as well.

Keith> [Perhaps Pierre knows? It was added here:

Definitely need a reply from Pierre...

Keith> -         for (i = 0; i <= namelen; i++)
Keith> -           {
Keith> -             if ((tokstart[i] >= 'a' && tokstart[i] <= 'z'))
Keith> -               tokstart[i] -= ('a'-'A');
Keith> -           }

Not your problem, Keith, but there's other code in that file that ought
to be using the ctypes macros instead of this stuff.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]