This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/7] Remove ada-varobj.h.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 17 Oct 2013 09:46:42 +0400
- Subject: Re: [PATCH 7/7] Remove ada-varobj.h.
- Authentication-results: sourceware.org; auth=none
- References: <1379512482-31773-1-git-send-email-yao at codesourcery dot com> <1379512482-31773-8-git-send-email-yao at codesourcery dot com>
> As a result of previous patch, extern functions in ada-varobj.c can be
> made static, and ada-varobj.h can be removed too.
>
> gdb:
>
> 2013-09-18 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
> * ada-varobj.c: Remove the include of ada-varobj.h.
> (ada_varobj_get_number_of_children): Declare.
> (ada_varobj_get_name_of_child): Make it static.
> (ada_varobj_get_path_expr_of_child): Likewise.
> (ada_varobj_get_value_of_child): Likewise.
> (ada_varobj_get_type_of_child): Likewise.
> (ada_varobj_get_value_of_array_variable): Likewise.
> * ada-varobj.h: Remove.
Thank you. OK to commit with one minor nit:
> @@ -57,6 +56,9 @@
>
> The results are written in place. */
>
> +static int ada_varobj_get_number_of_children (struct value *parent_value,
> + struct type *parent_type);
> +
> static void
> ada_varobj_decode_var (struct value **value_ptr, struct type **type_ptr)
> {
That declaration needs to be inserted _before_ the comment describing
ada_varobj_decode_var.
--
Joel