This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] add gdbarch_in_function_epilogue_p hook for sparc64
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 16 Oct 2013 17:53:46 -0300
- Subject: Re: [PATCH] add gdbarch_in_function_epilogue_p hook for sparc64
- Authentication-results: sourceware.org; auth=none
- References: <87mwm9b8pr dot fsf at oracle dot com>
On Wednesday, October 16 2013, Jose E. Marchesi wrote:
> Hi.
>
[...]
> 2013-10-16 Jose E. Marchesi <jose.marchesi@oracle.com>
>
> * sparc-tdep.c (sparc_in_function_epilogue_p): New function.
> (X_RETTURN): New macro.
> * sparc-tdep.h: sparc_in_function_epilogue_p prototype.
>
> * sparc64-tdep.c (sparc64_init_abi): Hook
> sparc_in_function_epilogue_p.
>
>
[...]
> Index: sparc-tdep.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/sparc-tdep.h,v
> retrieving revision 1.33
> diff -u -r1.33 sparc-tdep.h
> --- sparc-tdep.h 1 Jan 2013 06:32:51 -0000 1.33
> +++ sparc-tdep.h 16 Oct 2013 14:00:49 -0000
> @@ -193,6 +193,9 @@
> extern struct sparc_frame_cache *
> sparc32_frame_cache (struct frame_info *this_frame, void **this_cache);
>
> +extern int
> +sparc_in_function_epilogue_p (struct gdbarch *gdbarch, CORE_ADDR pc);
Not really a review, but the function name should not start on column 0
for prototypes.
Thanks,
--
Sergio