This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 05/18] poison "private"


On 10/14/2013 04:36 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> BTW, I think it'd be much clearer if we renamed away all this
> Pedro> 'private' wording, like, say:
> 
> Pedro>   struct private_thread_info -> struct target_thread_info
> 
> For the specific case of struct private_inferior, I think it would be
> better to change the code to use the existing registry API.

Yeah.  A key per stratum perhaps?  Not clear to me we'd
want each target to register its own key, which would result
in each thread_info holding a pointer for each target that
might be linked into gdb (that might want to attach info),
even though only one target per-stratum of those could be
owner of the data.

Though, that'd be a deeper change, compared to a simple
rename which should result in no functional difference.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]