This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/7] Move struct varobj to varobj.h.
- From: Yao Qi <yao at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 14 Oct 2013 16:18:08 +0800
- Subject: Re: [PATCH 4/7] Move struct varobj to varobj.h.
- Authentication-results: sourceware.org; auth=none
- References: <1379512482-31773-1-git-send-email-yao at codesourcery dot com> <1379512482-31773-5-git-send-email-yao at codesourcery dot com> <20131002094636 dot GC2971 at adacore dot com> <525103F5 dot 90607 at codesourcery dot com> <20131008045620 dot GD3092 at adacore dot com>
On 10/08/2013 12:56 PM, Joel Brobecker wrote:
It does look a lot better to me, FWIW. The only possibly contentious
question left would be making struct varobj public, when I personally
tend to prefer opaque structures. But I'm fine with this step, as it
helps achieve the goal of moving the language-specific stuff out of
varobj.c. I think Doug also pretty much agreed to that change. I would
give the patch, say, until the end of the week, JIC others want to
comment in.
> #if HAVE_PYTHON
> if (gdb_python_initialized)
> {
>- PyObject *value_formatter = var->pretty_printer;
>+ PyObject *value_formatter= var->dynamic->pretty_printer;
You accidently removed a space before '='.
Oh, fixed.
>+/* Every variable in the system has a structure of this type defined
>+ for it. This structure holds all information necessary to manipulate
>+ a particular object variable. Members which must be freed are noted. */
>+struct varobj
>+{
Not sure if there is a rule for it, or not. But I tend to prefer an
empty line between documentation and structure as well (same as with
subprograms). Add it if you agree, or else feel free to ignore. This
is just an arbitrary preference, AFAIK, and it really does not matter
much to me.
I am fine to add a blank between doc and structure. Patch is committed.
--
Yao (éå)