This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 17/18] fix gdbarch buglet
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Ondrej Oprala <ooprala at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Sun, 13 Oct 2013 19:35:40 +0200
- Subject: Re: [PATCH 17/18] fix gdbarch buglet
- Authentication-results: sourceware.org; auth=none
- References: <1381339053-14519-1-git-send-email-ooprala at redhat dot com> <1381339053-14519-18-git-send-email-ooprala at redhat dot com>
On Wed, 09 Oct 2013 19:17:32 +0200, Ondrej Oprala wrote:
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -17,6 +17,17 @@
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
>
> + * gdbarch.c (byte_order) : Change type.
> + (byte_order_for_code) : Likewise.
> + (gdbarch_byte_order) : Change type of the return value.
> + (gdbarch_byte_order_for_code) : Likewise.
> + * gdbarch.h (gdbarch_byte_order) : Change type of the return value.
> + (gdbarch_byte_order_for_code) : Likewise.
Again gdbarch.c and gdbarch.h are generated from gdbarch.sh and should be only
regenerated in description of the ChangeLog, as described by Pedro.
> + * gdbarch.sh (byte_order) : Change description.
> + (byte_order_for_code) : Likewise.
It is not "description" but "return type".
> +
> +2013-10-09 Tom Tromey <tromey@redhat.com>
> +
> * gdbtypes.h : Unbundle structures nested in union flds_bnds.
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
[...]
OK with the patch itself.
Thanks,
Jan