This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 05/18] poison "private"
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Ondrej Oprala <ooprala at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Sun, 13 Oct 2013 18:45:09 +0200
- Subject: Re: [PATCH 05/18] poison "private"
- Authentication-results: sourceware.org; auth=none
- References: <1381339053-14519-1-git-send-email-ooprala at redhat dot com> <1381339053-14519-6-git-send-email-ooprala at redhat dot com>
On Wed, 09 Oct 2013 19:17:20 +0200, Ondrej Oprala wrote:
[...]
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -17,6 +17,17 @@
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
>
> + * gdbthread.h (private_data) : Renamed from private.
Use tab + parentheses always contain only the global object name, in this case
"struct thread_info". And s/ : /: /. Therefore:
* gdbthread.h (struct thread_info): Rename field private to
private_data.
One could also use:
* gdbthread.h (struct thread_info): Rename the field to private_data.
> + * inferior.c (private_data) : Likewise.
> + * inferior.h (private_data) : Likewise.
> + * jit.c (private_unwind) : Likewise.
> + * linux-thread-db.c (private_data, private_thr) : Likewise.
> + * nto-tdep.c (private_data) : Likewise.
> + * remote.c (private_data) : Likewise.
> + * thread.c (private_dtor, private_data) : Likewise.
Incorrect parentheses content like above.
> +
> +2013-10-09 Tom Tromey <tromey@redhat.com>
> +
> * gdbtypes.c (is_public): Renamed from public.
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
[...]
The patch itself is OK to commit.
Thanks,
Jan