This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Disassembly readability (/r no spaces)


Attached patch improves disassemble/r readability

Rationale:

compare this libudis64 output:
0x7ffff7fb88e9 0xcc1 488945e8                 	mov %rax, -0x18(%rbp)
0x7ffff7fb88ed 0xcc5 488b45f0                 	mov -0x10(%rbp), %rax
0x7ffff7fb88f1 0xcc9 488b4038                 	mov 0x38(%rax), %rax
0x7ffff7fb88f5 0xccd 488945f0                 	mov %rax, -0x10(%rbp)
0x7ffff7fb88f9 0xcd1 813805002500             	cmp $0x250005, (%rax)
0x7ffff7fb88ff 0xcd7 741e                     	jz 0xcf7
0x7ffff7fb8901 0xcd9 488b45f0                 	mov -0x10(%rbp), %rax
0x7ffff7fb8905 0xcdd 488945e8                 	mov %rax, -0x18(%rbp)
0x7ffff7fb8909 0xce1 488bbd70ffffff           	mov -0x90(%rbp), %rdi
0x7ffff7fb8910 0xce8 488b75f0                 	mov -0x10(%rbp), %rsi
0x7ffff7fb8914 0xcec 48b84a9fb8f7ff7f0000     	mov $0x7ffff7b89f4a, %rax
0x7ffff7fb891e 0xcf6 ffd0                     	call *%rax
0x7ffff7fb8920 0xcf8 eb04                     	jmp 0xcfe
0x7ffff7fb8922 0xcfa 488b45f0                 	mov -0x10(%rbp), %rax
0x7ffff7fb8926 0xcfe 488b4008                 	mov 0x8(%rax), %rax
0x7ffff7fb892a 0xd02 488bbd70ffffff           	mov -0x90(%rbp), %rdi
0x7ffff7fb8931 0xd09 488b75f0                 	mov -0x10(%rbp), %rsi
0x7ffff7fb8935 0xd0d 488b55e8                 	mov -0x18(%rbp), %rdx
0x7ffff7fb8939 0xd11 ffd0                     	call *%rax
0x7ffff7fb893b 0xd13 488945f0                 	mov %rax, -0x10(%rbp)
0x7ffff7fb893f 0xd17 488bbd70ffffff           	mov -0x90(%rbp), %rdi
0x7ffff7fb8946 0xd1e 488b75f8                 	mov -0x8(%rbp), %rsi
0x7ffff7fb894a 0xd22 488b55f0                 	mov -0x10(%rbp), %rdx
0x7ffff7fb894e 0xd26 48b8f6f1baf7ff7f0000     	mov $0x7ffff7baf1f6, %rax
0x7ffff7fb8958 0xd30 ffd0                     	call *%rax
0x7ffff7fb895a 0xd32 488945f8                 	mov %rax, -0x8(%rbp)
0x7ffff7fb895e 0xd36 488b45f8                 	mov -0x8(%rbp), %rax
0x7ffff7fb8962 0xd3a c9                       	leave
0x7ffff7fb8963 0xd3b c3                       	ret

against the current gdb output:
   0x00007ffff7ff035b:	f7 c0 f8 ff ff ff	test   $0xfffffff8,%eax
   0x00007ffff7ff0361:	74 0c	je     0x7ffff7ff036f
   0x00007ffff7ff0363:	81 38 04 00 25 00	cmpl   $0x250004,(%rax)
   0x00007ffff7ff0369:	75 04	jne    0x7ffff7ff036f
   0x00007ffff7ff036b:	48 89 50 08	mov    %rdx,0x8(%rax)
   0x00007ffff7ff036f:	48 89 55 b0	mov    %rdx,-0x50(%rbp)
   0x00007ffff7ff0373:	48 b8 6f 00 00 00 00 00 00 00	movabs $0x6f,%rax
   0x00007ffff7ff037d:	48 89 45 f8	mov    %rax,-0x8(%rbp)
   0x00007ffff7ff0381:	48 8b 55 f8	mov    -0x8(%rbp),%rdx
   0x00007ffff7ff0385:	48 8b 45 a8	mov    -0x58(%rbp),%rax
   0x00007ffff7ff0389:	f6 c0 01	test   $0x1,%al
   0x00007ffff7ff038c:	75 14	jne    0x7ffff7ff03a2
   0x00007ffff7ff038e:	f7 c0 f8 ff ff ff	test   $0xfffffff8,%eax
   0x00007ffff7ff0394:	74 0c	je     0x7ffff7ff03a2
   0x00007ffff7ff0396:	81 38 04 00 25 00	cmpl   $0x250004,(%rax)
   0x00007ffff7ff039c:	75 04	jne    0x7ffff7ff03a2
   0x00007ffff7ff039e:	48 89 50 08	mov    %rdx,0x8(%rax)
   0x00007ffff7ff03a2:	48 89 55 a8	mov    %rdx,-0x58(%rbp)
   0x00007ffff7ff03a6:	48 8b bd 70 ff ff ff	mov    -0x90(%rbp),%rdi
   0x00007ffff7ff03ad:	48 8b b5 68 ff ff ff	mov    -0x98(%rbp),%rsi
   0x00007ffff7ff03b4:	48 b8 03 00 00 00 00 00 00 00	movabs $0x3,%rax
   0x00007ffff7ff03be:	48 89 45 f8	mov    %rax,-0x8(%rbp)
   0x00007ffff7ff03c2:	48 8b 55 f8	mov    -0x8(%rbp),%rdx
0x00007ffff7ff03c6: 48 b8 9d 9d bc f7 ff 7f 00 00 movabs $0x7ffff7bc9d9d,%rax
   0x00007ffff7ff03d0:	ff d0	callq  *%rax
   0x00007ffff7ff03d2:	48 89 45 f8	mov    %rax,-0x8(%rbp)
0x00007ffff7ff03d6: 48 b8 68 50 f8 f7 ff 7f 00 00 movabs $0x7ffff7f85068,%rax
   0x00007ffff7ff03e0:	48 89 85 70 ff ff ff	mov    %rax,-0x90(%rbp)
   0x00007ffff7ff03e7:	48 8b bd 70 ff ff ff	mov    -0x90(%rbp),%rdi
   0x00007ffff7ff03ee:	48 8b 75 a8	mov    -0x58(%rbp),%rsi
0x00007ffff7ff03f2: 48 b8 b0 ad b8 f7 ff 7f 00 00 movabs $0x7ffff7b8adb0,%rax
   0x00007ffff7ff03fc:	ff d0	callq  *%rax
   0x00007ffff7ff03fe:	48 89 c2	mov    %rax,%rdx
   0x00007ffff7ff0401:	48 89 45 a8	mov    %rax,-0x58(%rbp)
   0x00007ffff7ff0405:	48 8b 45 f8	mov    -0x8(%rbp),%rax
   0x00007ffff7ff0409:	48 89 50 38	mov    %rdx,0x38(%rax)
   0x00007ffff7ff040d:	48 8b 55 f8	mov    -0x8(%rbp),%rdx
   0x00007ffff7ff0411:	48 8b 45 a0	mov    -0x60(%rbp),%rax
   0x00007ffff7ff0415:	f6 c0 01	test   $0x1,%al
   0x00007ffff7ff0418:	75 14	jne    0x7ffff7ff042e
   0x00007ffff7ff041a:	f7 c0 f8 ff ff ff	test   $0xfffffff8,%eax
   0x00007ffff7ff0420:	74 0c	je     0x7ffff7ff042e


2013-10-11  Reini Urban  <rurban@cpanel.net>

	* disasm.c (dump_insns): Remove spacer = " "


--
Reini
>From 9825d8619f4b74ebbc572ae8d240ce46ac0225de Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@cpanel.net>
Date: Fri, 11 Oct 2013 11:18:04 -0500
Subject: [PATCH] disasm.c (dump_insns): Remove spacer = " "

Improve disassemble/r readability
---
 gdb/disasm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/disasm.c b/gdb/disasm.c
index e643c2d..d1ba103 100644
--- a/gdb/disasm.c
+++ b/gdb/disasm.c
@@ -169,7 +169,6 @@ dump_insns (struct gdbarch *gdbarch, struct ui_out *uiout,
                 (*di->memory_error_func) (status, old_pc, di);
               fprintf_filtered (opcode_stream, "%s%02x",
                                 spacer, (unsigned) data);
-              spacer = " ";
             }
           ui_out_field_stream (uiout, "opcodes", opcode_stream);
           ui_out_text (uiout, "\t");
-- 
1.8.4.rc3


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]