This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit/Ada] psymbol search failure due to comparison function discrepancy


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> This patch aims at restoring the compatibility between the two
Joel> functions, by adding case-sensitivity handling in the Ada comparison
Joel> function.

Joel> Tested on x86_64-linux. No testcase unfortunately, as the problem
Joel> is sensitive to symbol names and ordering, and the only reproducer
Joel> we have has non-contributable code in it.

Is it possible to construct a synthetic test case using the DWARF assembler?

I ask because I think that, while the patch is fine, having two
functions which must remain in sync semantically, where one such
function is only used by Ada and has no test case for some branches, is
definitely going to cause future regressions.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]