This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.


>>>>> "Nicolas" == Nicolas Blanc <nicolas.blanc@intel.com> writes:

Nicolas> 2013-17-06  Nicolas Blanc  <nicolas.blanc@intel.com>
Nicolas> 	* symfile.c (add_target_sections_of_objfile): New function.
Nicolas> 	(add_symbol_file_command): Update the current target sections.
Nicolas> 	(symfile_free_objfile): New function.
Nicolas> 	(_initialize_symfile): Attach observer for free_objfile.

Could you explain this one a bit?

Nicolas> +static void
Nicolas> +add_target_sections_of_objfile (struct objfile *objfile)

I'd like it better, I think, if some of the code in this function were
either moved to exec.c alongside the other target_sections-manipulating
functions, or just used them directly somehow.

Nicolas> +  if (objfile->flags & OBJF_USERLOADED)

Needs an explicit "!= 0".

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]