This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/7] New lang-varobj.h
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 9 Oct 2013 16:56:13 -0700
- Subject: Re: [PATCH 5/7] New lang-varobj.h
- Authentication-results: sourceware.org; auth=none
- References: <1379512482-31773-1-git-send-email-yao at codesourcery dot com> <1379512482-31773-6-git-send-email-yao at codesourcery dot com> <21068 dot 21875 dot 734416 dot 904684 at ruffy dot mtv dot corp dot google dot com> <20131008045901 dot GE3092 at adacore dot com> <5255EBB3 dot 1050700 at codesourcery dot com>
On Wed, Oct 9, 2013 at 4:50 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 10/08/2013 12:59 PM, Joel Brobecker wrote:
>>>
>>> >How about move lang-varobj.h into varobj.h?
>>
>> Not very important in the grand scheme of things, but I tend to agree
>> with the suggestion. If we had a lang-varobj.c, things might be
>> different. But for a simple definition of the language-specific ops
>> directly related to varobj, I'd keep things simple, inside varobj.h.
>
>
> We don't have lang-varobj.c, but we'll have c-varobj.c, jv-varobj.c and
> ada-varobj.c [done by patch 6/7]. Is it strong enough to justify creating
> new file lang-varobj.h?
"Well ..."
All it has is one struct, there's not much point to it right now.