This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Tom Tromey <tromey at redhat dot com>, ktietz at redhat dot com, gdb-patches at sourceware dot org
- Date: Wed, 9 Oct 2013 19:41:24 +0200
- Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
- Authentication-results: sourceware.org; auth=none
- References: <20131008183214 dot GB27355 at host2 dot jankratochvil dot net> <87li23fsym dot fsf at fleche dot redhat dot com> <20131009131016 dot GA1603 at host2 dot jankratochvil dot net> <83hacqqsx7 dot fsf at gnu dot org> <87ob6ybcdc dot fsf at fleche dot redhat dot com> <83bo2yqrop dot fsf at gnu dot org>
On Wed, 09 Oct 2013 19:28:54 +0200, Eli Zaretskii wrote:
> This patch confused me: it tests whether O_CLOEXEC is zero, which it
> is on Windows, so there should be no need to try "e" at all.
If O_CLOEXEC is 0 then the "e" flag is not tried at all, therefore it could
not crash on MS-Windows.
> Therefore, I don't understand why this is still an issue. What am I
> missing?
On platforms where O_CLOEXEC is 0 this new patch has no effect.
Jan