This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Minor O_CLOEXEC optimization, "regression" fix


On Wed, 09 Oct 2013 19:28:54 +0200, Eli Zaretskii wrote:
> This patch confused me: it tests whether O_CLOEXEC is zero, which it
> is on Windows, so there should be no need to try "e" at all.

If O_CLOEXEC is 0 then the "e" flag is not tried at all, therefore it could
not crash on MS-Windows.


> Therefore, I don't understand why this is still an issue.  What am I
> missing?

On platforms where O_CLOEXEC is 0 this new patch has no effect.


Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]