This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv2] Minor O_CLOEXEC optimization, "regression" fix
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Kai Tietz <ktietz at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 09 Oct 2013 09:48:18 -0600
- Subject: Re: [patchv2] Minor O_CLOEXEC optimization, "regression" fix
- Authentication-results: sourceware.org; auth=none
- References: <20131008183214 dot GB27355 at host2 dot jankratochvil dot net> <87li23fsym dot fsf at fleche dot redhat dot com> <20131009131016 dot GA1603 at host2 dot jankratochvil dot net> <173490856 dot 4156973 dot 1381325657769 dot JavaMail dot root at redhat dot com> <20131009144134 dot GA7506 at host2 dot jankratochvil dot net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> On Wed, 09 Oct 2013 15:34:17 +0200, Kai Tietz wrote:
>> So yes, probing for EINVAL seems to me like a valid way to probe for valid
>> arguments here.
Jan> OK, therefore updated the patch.
Jan> No regressions on {x86_64,x86_64-m32,i686}-fedora21pre-linux-gnu.
Jan> It still reduces the number of syscalls.
Looks good to me.
Tom