This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/7] Move struct varobj to varobj.h.


On 10/08/2013 12:56 PM, Joel Brobecker wrote:
It does look a lot better to me, FWIW.  The only possibly contentious
question left would be making struct varobj public, when I personally
tend to prefer opaque structures. But I'm fine with this step, as it
helps achieve the goal of moving the language-specific stuff out of
varobj.c. I think Doug also pretty much agreed to that change. I would
give the patch, say, until the end of the week, JIC others want to
comment in.

OK.


How does this new patch affect the rest of the patch series? No effect?
If not, we can continue reviewing the remainder.  Otherwise, can you
post an update?  Sorry it's taking so long. I just don't have much time.
But as I said, I like the direction this is taking.

It affects patch 6/7.  I'll post an update.

--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]