This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/7] Move struct varobj to varobj.h.
- From: Yao Qi <yao at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 9 Oct 2013 08:26:33 +0800
- Subject: Re: [PATCH 4/7] Move struct varobj to varobj.h.
- Authentication-results: sourceware.org; auth=none
- References: <1379512482-31773-1-git-send-email-yao at codesourcery dot com> <1379512482-31773-5-git-send-email-yao at codesourcery dot com> <20131002094636 dot GC2971 at adacore dot com> <525103F5 dot 90607 at codesourcery dot com> <20131008045620 dot GD3092 at adacore dot com>
On 10/08/2013 12:56 PM, Joel Brobecker wrote:
It does look a lot better to me, FWIW. The only possibly contentious
question left would be making struct varobj public, when I personally
tend to prefer opaque structures. But I'm fine with this step, as it
helps achieve the goal of moving the language-specific stuff out of
varobj.c. I think Doug also pretty much agreed to that change. I would
give the patch, say, until the end of the week, JIC others want to
comment in.
OK.
How does this new patch affect the rest of the patch series? No effect?
If not, we can continue reviewing the remainder. Otherwise, can you
post an update? Sorry it's taking so long. I just don't have much time.
But as I said, I like the direction this is taking.
It affects patch 6/7. I'll post an update.
--
Yao (éå)