This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/7] New lang-varobj.h
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Tue, 8 Oct 2013 08:59:01 +0400
- Subject: Re: [PATCH 5/7] New lang-varobj.h
- Authentication-results: sourceware.org; auth=none
- References: <1379512482-31773-1-git-send-email-yao at codesourcery dot com> <1379512482-31773-6-git-send-email-yao at codesourcery dot com> <21068 dot 21875 dot 734416 dot 904684 at ruffy dot mtv dot corp dot google dot com>
> > 2013-09-18 Yao Qi <yao@codesourcery.com>
> >
> > * Makefile.in (HFILES_NO_SRCDIR): Add lang-varobj.h.
> > * lang-varobj.h: New.
> > * varobj.c: Include "lang-varobj.h".
> > (struct varobj_root): <lang>: Update its type.
> > (struct language_specific): Move it to lang-varobj.h.
>
> Hi.
>
> How about move lang-varobj.h into varobj.h?
Not very important in the grand scheme of things, but I tend to agree
with the suggestion. If we had a lang-varobj.c, things might be
different. But for a simple definition of the language-specific ops
directly related to varobj, I'd keep things simple, inside varobj.h.
--
Joel