This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/7 V2] Trust readonly sections if target has memory protection


On 9/30/13 11:08 AM, Pedro Alves wrote:
> On 09/30/2013 06:50 PM, Pedro Alves wrote:
> 
>> But in cases like disassembly, we're being driven by debug
>> info or user input.  As GDB knows upfront the whole range of memory it'll
>> be fetching, accessing a bigger chunk upfront, as long as it doesn't
>> step out of the range we read piecemeal anyway, should have no effect
>> on correctness.
> 
> Hmm, wait, I'm having a a dÃjà vu experience.  I recalled I have
> once reviewed a patch that does exactly this.  But, I'm not finding
> it in the tree, or in the archives.  Maybe it was a CS local patch
> that was never pushed?
> 

There are a couple possibilities - for instance there we had a request
to check that the code underneath a breakpoint had not changed behind
our backs, or something like that.  There was also the check of readonly
areas for memory_xfer_partial reading from a traceframe, but
that was your code, and it went into FSF in February 2011. :-)

Stan
stan@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]