This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix mi-support.exp to have consistent test names


>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> The "varobj_tree" code in mi-support.exp keeps a counter to try to
Tom> ensure that test names are unique.

Tom> However, this counter is never reset, only incremented.  What this
Tom> means is that the test names depend on the order of calls into this
Tom> code.  This is not good if you want to run the tests independently.

Tom> This patch fixes the issue by resetting the counter on each call to
Tom> varobj_tree::walk_tree.

Tom> This change did not result in any new non-unique test names in gdb.mi.

Tom> It does change some test names, of course, so be warned about that.

I'm checking this in now.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]