This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi.


On 7 October 2013 06:02, Joel Brobecker <brobecker@adacore.com> wrote:
>> If we are running on a Linux platform we should call linux_init_abi
>> in order to get all the useful hooks it enables.
>>
>> gdb/ChangeLog:
>>
>> 2013-10-04  Will Newton  <will.newton@linaro.org>
>>
>>       * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call
>>       linux_init_abi.
>
> This makes sense to me, and it's actually what the 32bit side of
> the code is already doing. OK to apply.

I'll wait a couple of days to see if anyone from ARM objects.

> It'd be nice also if you could confirm that this patch was tested
> prior to submitting, and how it affects the testsuite results.
> This often helps future research...

The patch was tested manually to check that things like "info proc
maps" now works. The testsuite is in pretty bad shape on aarch64 but
no new failures are added.

-- 
Will Newton
Toolchain Working Group, Linaro


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]