This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/6] Move notif_queue to remote_state


On 10/01/2013 01:08 AM, Pedro Alves wrote:
-static void
>-notif_xfree (struct notif_client *notif)
...
>-  if (notif->pending_event != NULL
>-      && notif->pending_event->dtr != NULL)
>-    notif->pending_event->dtr (notif->pending_event);
Hmm, it's not clear to me from reading the patch where is
pending_event released after this patch.  Could you help
me understand that?

Since notif_queue is a global variable, we've never used QUEUE_free to
free notif_queue, so notif_xfree is never called, and pending_event on each notif_client is not released.

When we move notif_queue to 'remote_notif_state', we have to explicitly use QUEUE_free to free notif_queue and elements in it. We put the pointer of each notif_client to notif_queue, so we don't need a function to free the notif_client when notif_queue is destroyed. So the notif_queue is allocated like this,

notif_state->notif_queue = QUEUE_alloc (notif_client_p, NULL);

and notif_xfree is not needed any more. The leak on pending_event is still there, but it is fixed by the next patch, which moves pending_event to remote_notif_state, and pending_event is freed in remote_notif_state_xfree.

--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]