This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/7] Remove vlang_unknown
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 1 Oct 2013 17:19:20 -0700
- Subject: Re: [PATCH 2/7] Remove vlang_unknown
- Authentication-results: sourceware.org; auth=none
- References: <1379512482-31773-1-git-send-email-yao at codesourcery dot com> <1379512482-31773-3-git-send-email-yao at codesourcery dot com> <20131001100742 dot GC2840 at adacore dot com> <524ACF04 dot 2050904 at codesourcery dot com>
On Tue, Oct 1, 2013 at 6:32 AM, Yao Qi <yao@codesourcery.com> wrote:
> On 10/01/2013 06:07 PM, Joel Brobecker wrote:
>>
>> I am not really sure why the first enum would need to be zero.
>> If we cannot find an answer to that question, I propose you leave
>> the "= 0" out of this patch.
>
>
> In varobj.c:varobj_create, variable_language returns
> 'enum varobj_languages', and use it as an index to array
> languages.
>
> /* Set language info */
> lang = variable_language (var);
> var->root->lang = &languages[lang];
>
> that is the reason the first enum should be zero.
While we know enums begin at zero, making it explicit is fine with me.
But if there's a reason that needed explaining, a comment in the code
explaining "Why things are the way they are"
is most welcome.