This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/7] Remove vlang_unknown


> 2013-09-18  Yao Qi  <yao@codesourcery.com>
> 
> 	* varobj.c (varobj_format_string): Remove "unknown".
> 	(languages): Remove the first element.
> 	* varobj.h (enum varobj_languages): Remove vlang_c.

Overall, looks good to me.

> diff --git a/gdb/varobj.h b/gdb/varobj.h
> index 05b2c94..d4abb99 100644
> --- a/gdb/varobj.h
> +++ b/gdb/varobj.h
> @@ -55,7 +55,7 @@ extern char *varobj_format_string[];
>  /* Languages supported by this variable objects system.  */
>  enum varobj_languages
>    {
> -    vlang_unknown = 0, vlang_c, vlang_cplus, vlang_java, vlang_ada, vlang_end
> +    vlang_c = 0, vlang_cplus, vlang_java, vlang_ada, vlang_end

I am not really sure why the first enum would need to be zero.
If we cannot find an answer to that question, I propose you leave
the "= 0" out of this patch.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]