This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC 5/6] Handle "set print sevenbit-strings on" in print_wchar


On 09/26/2013 01:03 PM, Pierre Muller wrote:

2013-09-26  Pierre Muller  <muller@sourceware.org>

  	valprint.c (print_wchar): Honor sevenbit_strings value.


[Your ChangeLog entry got munged...] I would prefer that you ChangeLog entry be a little more explicit about what changed, e.g., "Print escaped characters if sevenbit-strings is set."

I think this patch is okay, but it definitely needs a test (and a maintainer to approve). It took me a non-trivial amount of time to actually get the patch to show any difference in the output.

The trick (on linux) was changing the charset to something where (char)0x80 and up are printable characters. I used CP1252, and then I could see what this patch actually did.

Perhaps this can be used in a test that will run on more than just MinGW hosts.

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]