This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] PR gdb/11568 - delete thread-specific breakpoints on thread exit
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Muhammad Waqas <mwaqas at codesourcery dot com>
- Date: Mon, 09 Sep 2013 10:07:33 -0600
- Subject: Re: [PATCH] PR gdb/11568 - delete thread-specific breakpoints on thread exit
- Authentication-results: sourceware.org; auth=none
- References: <521CF7D0 dot 5040801 at redhat dot com> <1377692710-2885-1-git-send-email-mwaqas at codesourcery dot com> <5224C0EB dot 3000503 at redhat dot com> <5224C238 dot 2060106 at redhat dot com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Here it is. Let me know what you all think.
It looks good to me.
Pedro> There's no way that breakpoint can trigger again (*), so the PR argues
Pedro> that the breakpoint should just be removed, like local watchpoints.
Pedro> I'm ambivalent on this -- it could be reasonable to disable the
Pedro> breakpoint (kind of like breakpoint in shared library code when the
Pedro> DSO is unloaded), so the user could still use it as visual template
Pedro> for creating other breakpoints (copy/paste command lists, etc.), or we
Pedro> could have a way to change to which thread a breakpoint applies. But,
Pedro> several people pushed this direction, and I don't plan on arguing...
I've sometimes wished for a way to modify a breakpoint in place.
There may be another PR about this.
But it's fine to put in this patch now and remove it again later if
anyone actually implements breakpoint modification.
Tom