This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix gdb.base/shreloc.exp: (msymbol) relocated functions have different addresses fail in cygwin
- From: Hui Zhu <teawater at gmail dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Mon, 9 Sep 2013 22:26:36 +0800
- Subject: Re: [PATCH] Fix gdb.base/shreloc.exp: (msymbol) relocated functions have different addresses fail in cygwin
- Authentication-results: sourceware.org; auth=none
- References: <CANFwon0RVVQKLg2Ffm+TWQSKrJRTTtZ-573iJQ_T_HWMrm1hGQ at mail dot gmail dot com> <522DD104 dot 6090808 at codesourcery dot com>
On Mon, Sep 9, 2013 at 9:45 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 09/09/2013 04:40 PM, Hui Zhu wrote:
>>
>> - send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
>> + if { "${plus_var}" == "" } {
>> + send_gdb "shell grep -E \" ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
>> + } else {
>> + send_gdb "shell grep -E \" ${plus_var} .* ${var}(\[ \t\]+.*)?\$\"
>> ${msymfile}\n"
>> + }
>
>
> Why don't do this unconditionally?
>
> send_gdb "shell grep -E \" T .* ${var}(\[ \t\]+.*)?\$\" ${msymfile}\n"
Because other test use this function too.
Thanks,
Hui
>
> --
> Yao (éå)