This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFC 2/3] Perf test framework
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Yao Qi' <yao at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 3 Sep 2013 06:37:54 +0000
- Subject: RE: [RFC 2/3] Perf test framework
- Authentication-results: sourceware.org; auth=none
- References: <520B7F70 dot 6070207 at codesourcery dot com> <1377663394-4975-1-git-send-email-yao at codesourcery dot com> <1377663394-4975-3-git-send-email-yao at codesourcery dot com> <0377C58828D86C4588AEEC42FC3B85A71765866D at IRSMSX105 dot ger dot corp dot intel dot com> <52253EFD dot 6040505 at codesourcery dot com>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Yao Qi
> Sent: Tuesday, September 03, 2013 03:44 AM
> To: Agovic, Sanimir
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFC 2/3] Perf test framework
>
> On 08/28/2013 05:57 PM, Agovic, Sanimir wrote:
> > I would put a copyright header and a module __doc__ into __init__.py
> >
>
> What do you mean by "put a module __doc__ into __init__.py"?
>
Add a comment in __init__.py and briefly describe the module, it will show up
during help(perftest)/pydoc.
> Abstract Base Class should be useful here. It was introduced in python
> 2.6, but GDB should support some older pythons. I don't know what are
> the versions of python GDB support, 2.4 ~ 3.0?, but some code in
> gdb/python/ is written with 2.4 considered.
>
I see. As an alternative you may consider throwing NotImplementedError instead.
> Other comments are addressed, and I'll post the updated patch in next
> round.
>
Thanks.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052