This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] cleanup: use value_lazy_at instead of allocate_value_lazy/attribute setter
- From: Tom Tromey <tromey at redhat dot com>
- To: Sanimir Agovic <sanimir dot agovic at intel dot com>
- Cc: gdb-patches at sourceware dot org, keven dot boell at intel dot com
- Date: Wed, 28 Aug 2013 13:11:52 -0600
- Subject: Re: [PATCH 2/3] cleanup: use value_lazy_at instead of allocate_value_lazy/attribute setter
- Authentication-results: sourceware.org; auth=none
- References: <1377697953-6954-1-git-send-email-sanimir dot agovic at intel dot com> <1377697953-6954-3-git-send-email-sanimir dot agovic at intel dot com>
>>>>> "Sanimir" == Sanimir Agovic <sanimir.agovic@intel.com> writes:
Sanimir> I came across a pattern used to construct a value in the following way:
Sanimir> struct value *val = allocate_value_lazy (type);
Sanimir> VALUE_LVAL (val) = lval_memory;
Sanimir> set_value_address (val, address);
Thanks for doing this.
Sanimir> 2013-08-27 Sanimir Agovic <sanimir.agovic@intel.com>
Sanimir> * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use value_at_lazy instead
Sanimir> of assembling value via allocate_value_lazy and attribute setter.
Sanimir> * findvar.c (default_read_var_value): Use value_at_lazy instead of
Sanimir> assembling value via allocate_value_lazy and attribute setter.
Sanimir> * valops.c (do_search_struct_field): Use value_at_lazy instead of
Sanimir> assembling value via allocate_value_lazy and attribute setter.
This is ok.
Tom