This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Use mi_getopt_silent
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 27 Aug 2013 12:43:13 +0100
- Subject: Re: [PATCH 1/2] Use mi_getopt_silent
- Authentication-results: sourceware.org; auth=none
- References: <51FA557F dot 5 at redhat dot com> <1377402123-3740-1-git-send-email-yao at codesourcery dot com> <1377402123-3740-2-git-send-email-yao at codesourcery dot com> <521B80B5 dot 1020108 at redhat dot com> <521C1CF9 dot 3060907 at codesourcery dot com>
On 08/27/2013 04:28 AM, Yao Qi wrote:
> On 08/27/2013 12:22 AM, Pedro Alves wrote:
>>>> -int
>>>> -mi_getopt (const char *prefix,
>>>> - int argc, char **argv,
>>>> - const struct mi_opt *opts,
>>>> - int *oind, char **oarg)
>>>> +/* See comments about mi_getopt and mi_getopt_silent in mi-getopt.h.
>>>> + When there is an unknown option, if ERROR_ON_UNKNOWN is true, it
>>>> + throws an error, otherwise return -1. */
>> ("throws" -> "returns"). I'd suggest:
>>
>
> I assume you meant "return" -> "returns" here.
Yeah, specifically, I meant, you have "it throws", so it should be
"it returns", as the subject is still "it".
> I also rename mi_getopt_silent to mi_getopt_allow_unknown.
Excellent! I like that.
--
Pedro Alves