This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5] powerpc64-aix processing xlC generated line table
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: raunaq12 at in dot ibm dot com (Raunaq 12)
- Cc: brobecker at adacore dot com, gdb-patches at sourceware dot org, palves at redhat dot com (Pedro Alves), tromey at redhat dot com
- Date: Mon, 26 Aug 2013 17:30:11 +0200 (CEST)
- Subject: Re: [PATCH 2/5] powerpc64-aix processing xlC generated line table
- Authentication-results: sourceware.org; auth=none
Raunaq Bathija wrote:
> "Ulrich Weigand" <uweigand@de.ibm.com> wrote on 08/09/2013 03:31:21 AM:
> > Well, the test suite is supposed to handle different compilers,
> > but since only very few people test with anything but GCC,
> > support for other compilers tends to bit-rot. As a suggestion
> > to help with future maintainability of GDB on AIX, it would be
> > nice if you could go through the test suite at some point and
> > clean those problems up ...
>
> Agreed, that would greatly help with future maintainablity of GDB on AIX.
> Will plan to take that task up once I am done fixing some other
> issues faced by GDB on AIX like stabstring support for XLC++ compiled
> binaries.
Thanks!
> Thanks for taking time to write this Ulrich. This does solve the problem
> but one
> extra line had to be added to update the number of items in the line table
> as
> seen below,
>
> - newLineTb->nitems = oldLineTb->nitems - function_count;
> + newLineTb->nitems = oldLineTb->nitems - function_count + extra_lines;
>
> Added this line and ran the related testcases. Results same as before.
>
> Can we go ahead and check this in?
Looks good, and thanks for testing! I've checked this in now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com