Re: [PATCH, gdbserver] Further cleanup of FDPIC/DSBT divergences

[Mike Frysinger <vapier at gentoo dot org>]

On Friday 09 August 2013 13:20:24 Luis Machado wrote:
> --- a/gdb/gdbserver/linux-low.c
> +++ b/gdb/gdbserver/linux-low.c
> 
>  }
> -#else
> -# define linux_read_loadmap NULL
> -#endif /* defined PT_GETDSBT || defined PTRACE_GETFDPIC */
> +#endif /* defined PTRACE_GETFDPIC */
> 
> @@ -6036,7 +6013,11 @@ static struct target_ops linux_target_ops = {
>    linux_common_core_of_thread,
> +#if defined PTRACE_GETFDPIC
>    linux_read_loadmap,
> +#else
> +  NULL,
> +#endif /* defined PTRACE_GETFDPIC */
>    linux_process_qsupported,
>    linux_supports_tracepoints,

personally, i liked the style before -- keep the logic where the func is 
defined rather than in the initialization of the target ops.

otherwise, the changes to the linux-low.c file LGTM
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.