This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Avoid unlimited height on mingw built GDB's.
- From: Yao Qi <yao at codesourcery dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 8 Aug 2013 17:17:30 +0800
- Subject: Re: [RFA] Avoid unlimited height on mingw built GDB's.
- References: <001c01ce9412$2c438df0$84caa9d0$ at muller@ics-cnrs.unistra.fr>
On 08/08/2013 04:35 PM, Pierre Muller wrote:
2013-08-08 Pierre Muller<muller@sourceware.org>
* src/gdb/utils.c (init_page_info): Only call tgetnum function
Remove "src/gdb/".
if rl_get_screen_size did not return useful values.
Index: src/gdb/utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.305
diff -u -p -r1.305 utils.c
--- src/gdb/utils.c 1 Aug 2013 09:09:58 -0000 1.305
+++ src/gdb/utils.c 7 Aug 2013 12:56:49 -0000
@@ -1660,12 +1660,16 @@ init_page_info (void)
lines_per_page = rows;
chars_per_line = cols;
It looks suspicious to me that we assign a signed integer to a unsigned
one, but it is not related to this patch.
I don't have comments on this patch. This issue was discussed in 2012
here http://sourceware.org/ml/gdb-patches/2012-10/msg00282.html and Eli
suggested that we can get rid of windows-termcap.c and use mingw
ncurses build for gdb, so we don't want to pursue this way?
--
Yao (éå)