This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] move gdbarch object from objfile to per-BFD
- From: Tom Tromey <tromey at redhat dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 05 Aug 2013 14:12:31 -0600
- Subject: Re: [PATCH] move gdbarch object from objfile to per-BFD
- References: <1375725385-11178-1-git-send-email-tromey at redhat dot com> <201308051811 dot r75IBJGq013284 at glazunov dot sibelius dot xs4all dot nl> <877gg07xz4 dot fsf at fleche dot redhat dot com> <201308051922 dot r75JMD4p020143 at glazunov dot sibelius dot xs4all dot nl>
>> I can add it. The reason I did not is that, for whatever reason,
>> objfiles have not historically used accessors. So, I preserved the
>> status quo in this respect.
Mark> Merely a suggestion. If you considered it and decided against it
Mark> that's fine with me.
I'm not sure why, but even though the patch changed get_objfile_arch, I
failed to think of that as an accessor. Weird; but I suppose since it
doesn't follow the usual gdb macro style. Anyway, I'll shortly send an
updated patch that uses get_objfile_arch at all the spots that read the
field. I left the writers alone, as there aren't many and we shouldn't
encourage more.
Tom