This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Update comments to list_args_or_locals.
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 05 Aug 2013 07:39:08 -0600
- Subject: Re: [PATCH] Update comments to list_args_or_locals.
- References: <1375663603-6308-1-git-send-email-yao at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2013-08-05 Yao Qi <yao@codesourcery.com>
Yao> * mi/mi-cmd-stack.c: Update comments to function
Yao> list_args_or_locals.
Yao> -/* Print a list of the locals or the arguments for the currently
Yao> - selected frame. If the argument passed is 0, printonly the names
Yao> - of the variables, if an argument of 1 is passed, print the values
Yao> - as well. */
Yao> +/* Print a list of the objects for the currently selected frame FI in
Yao> + a certain form, which is determined by VALUES. The objects can be
Yao> + locals, arguments or both, which is determined by WHAT. */
I think the bit about "currently selected frame FI" is odd. Usually
"currently selected frame" refers to the one the user chose with "up" or
"down".
Otherwise it seems fine to me.
Tom