This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] remove duplicates in search_symbols

From: Keith Seitz <keiths at redhat dot com>
To: Doug Evans <dje at google dot com>
Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
Date: Thu, 01 Aug 2013 20:39:46 -0700
Subject: Re: [RFA] remove duplicates in search_symbols
References: <yjt2ppvmu3ae dot fsf at ruffy dot mtv dot corp dot google dot com> <CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ at mail dot gmail dot com> <8738r68uze dot fsf at fleche dot redhat dot com> <20986 dot 62497 dot 975502 dot 698564 at ruffy dot mtv dot corp dot google dot com>

On 08/01/2013 04:49 PM, Doug Evans wrote:

struct symbol_search { ... };
extern void search_symbols (char *, enum search_domain, int, char **,
			    struct symbol_search **);
extern void free_search_symbols (struct symbol_search *);
extern struct cleanup *make_cleanup_free_search_symbols (struct symbol_search
							 **);

I'm semi-ambivalent about keeping them as an exported part of the API
so I left making them static for another pass.

FWIW, Insight uses struct symbol_search, search_symbols, andmake_cleanup_free_search_symbols. It would be nice if some sort ofpublic API for this was maintained.


Keith

Follow-Ups:
- Re: [RFA] remove duplicates in search_symbols
  - From: Tom Tromey

References:
- Re: [RFA] remove duplicates in search_symbols
  - From: Doug Evans

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]