This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 9/9] enable target-async
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 31 Jul 2013 14:26:44 -0600
- Subject: Re: [PATCH v2 9/9] enable target-async
- References: <1375295281-7040-1-git-send-email-tromey at redhat dot com> <1375295281-7040-10-git-send-email-tromey at redhat dot com> <20985 dot 29045 dot 586199 dot 345765 at ruffy dot mtv dot corp dot google dot com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>> +int mi_last_was_cli;
>> +
Doug> Delete? It's declared in mi-main.h.
Yeah. Sorry about this, I forgot to zap some old hacks I had been
trying out. Hence the commented-out code and other goo.
>> + if (!target_is_async_p () || !sync_execution)
Doug> Please add a comment explaining the condition here.
Doug> It loosely reads as !async || async.
Ok.
>> struct cleanup *back_to = make_cleanup_restore_integer (&sched_multi);
>>
>> + if (!target_async_permitted && target_can_async_p ())
>> + async_disable_stdin ();
>> +
Doug> A comment explaining why this is here would be helpful.
Doug> I thought target_can_async_p was just a capability flag, not something
Doug> specifying the current state of anything.
This mirrors a condition elsewhere.
I'll add a comment.
Tom