This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path.
- From: Pedro Alves <palves at redhat dot com>
- To: Muhammad Bilal <mbilal at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 30 Jul 2013 12:00:00 +0100
- Subject: Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path.
- References: <97B73E257CC18646B0B5D3DD77DCBDD15DA063 at EU-MBX-02 dot mgc dot mentorg dot com> <97B73E257CC18646B0B5D3DD77DCBDD15DA08C at EU-MBX-02 dot mgc dot mentorg dot com> <51F27050 dot 6060409 at redhat dot com> <51F607C7 dot 7020108 at codesourcery dot com> <51F67A1A dot 8060602 at redhat dot com> <51F78DB7 dot 8010902 at codesourcery dot com> <51F790BE dot 9020306 at redhat dot com> <51F799A2 dot 1030500 at codesourcery dot com>
On 07/30/2013 11:46 AM, Muhammad Bilal wrote:
> 2012-07-30 Muhammad Bilal <mbilal@codesorcery.com>
>
> PR gdb/15715
> * top.c: Include "filenames.h".
> (set_history_filename): New function.
> (init_main): Install it as set hook of the "set history filename"
> command.
>
> /testsuit
> 2012-07-30 Muhammad Bilal <mbilal@codesourcery.com>
>
> PR gdb/15715
> * gdb.base/setshow.exp: Test that relative paths passed to
> 'set history filename' are converted to absolute paths
You've lost the period at end of this sentence. It was there in
previous versions. I'd like to be sure you learn to pay attention to
these details, hence the multiple iterations, but I'd like to avoid
having to go through them for all patches. Please be attentive. This
is OK with the missing period added (though as penance, I really should
have you go through one more round of posting before approving. ;-) )
--
Pedro Alves