This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/7] MIPS support
- From: Doug Evans <dje at google dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Tom Tromey <tromey at redhat dot com>
- Date: Sat, 27 Jul 2013 10:22:19 -0700
- Subject: Re: [PATCH 7/7] MIPS support
- References: <1374869594-16965-1-git-send-email-sergiodj at redhat dot com> <1374869594-16965-8-git-send-email-sergiodj at redhat dot com>
Hi. Just a nit.
On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> Support for the MIPS target. MIPS already had a definition of
> gdbarch_gdb_signal_from_target, and also an enum containing all signal
> numbers from this target. So, in order to make things standard, I
> removed the previous enum in favor of the new, difference-only enum
> declared by this patch series. And I also redefined the implementation
> of gdbarch_gdb_signal_from_target for MIPS in order to take this new
> enum into account, and only handle the signals which are different from
> the Linux kernel generic ones.
>
> 2013-07-26 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * mips-linux-tdep.c: Define enum with differences between
> signals in MIPS and Linux kernel generic ones.
> (mips_gdb_signal_to_target): New function.
> (mips_gdb_signal_from_target): Redefine to use new enum, handle
> only different signals from the Linux kernel generic.
> (mips_linux_init_abi): Set gdbarch_gdb_signal_{to,from}_target
> the functions defined above.
> * mips_gdb_signal_to_target (enum mips_signals): Remove.
Nit: Fix changelog entry for mips-linux-tdep.h.