This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/7] SPARC support
- From: Doug Evans <dje at google dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Tom Tromey <tromey at redhat dot com>
- Date: Sat, 27 Jul 2013 10:13:29 -0700
- Subject: Re: [PATCH 5/7] SPARC support
- References: <1374869594-16965-1-git-send-email-sergiodj at redhat dot com> <1374869594-16965-6-git-send-email-sergiodj at redhat dot com>
Hi. Just a nit.
On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> Support for SPARC. It does not share some signal numbers, therefore
> there is the target-specific implementation for them.
>
> 2013-07-26 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * sparc-linux-tdep.c: Define enum with differences between SPARC
> and x86 signal numbers.
> (sparc32_linux_gdb_signal_from_target): New function.
> (sparc32_linux_gdb_signal_to_target): Likewise.
> (sparc32_linux_init_abi): Set gdbarch_gdb_signal_{to,from}_target
> to the functions defined above.
> [...]
> @@ -267,6 +292,113 @@ sparc32_linux_get_syscall_number (struct gdbarch *gdbarch,
>
> return ret;
> }
Nit: Missing blank line here.
> +/* Implementation of `gdbarch_gdb_signal_from_target', as defined in
> + gdbarch.h. */
> +
> +static enum gdb_signal
> +sparc32_linux_gdb_signal_from_target (struct gdbarch *gdbarch,
> + int signal)
> +{
> [...]