This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] New option --cygwin-tty.


On Jul 25 20:07, Yao Qi wrote:
> On 07/25/2013 06:19 PM, Corinna Vinschen wrote:
> >>What is the minimum version of cygwin required for this example?  In
> >>>cygwin 1.7.20, the file name is
> >>>"\cygwin-8c26184c318518a4-pty0-from-master", while in 1.7.9, it is
> >>>"\cygwin-c5e39b7a9d22bafb-tty0-from-master".
> >Read the source code comments.  The hex number is a per-installation
> >hash value which does not tell anything about the Cygwin version.  The
> >earliest supported Cygwin version is 1.7.0, so the answer is "all of
> >them" for all practical purposes.
> 
> My point was about the "pty0" vs "tty0" difference in the file name.
> If the difference is expected, I'll update the name pattern in the
> code. Your example expects to see "pty".

Oh, ok, I missed that.  Just tweak the code to check for both if you
want to support old Cygwin versions.  But this isn't necessary IMO.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]