This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/testsuite/gdb.dwarf2: Replaces @ with % sign to allow tests stay compatible with both arm and x86 assembly
- From: Will Newton <will dot newton at linaro dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Omair Javaid <omair dot javaid at linaro dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 19 Jul 2013 11:02:05 +0100
- Subject: Re: [PATCH] gdb/testsuite/gdb.dwarf2: Replaces @ with % sign to allow tests stay compatible with both arm and x86 assembly
- References: <CANW4E-25m0GrfpR7XTYVRYOKwkpXgLvtMnNdriaR_DkPM=cNfQ at mail dot gmail dot com> <87r4exf45p dot fsf at fleche dot redhat dot com>
On 17 July 2013 19:10, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Omair" == Omair Javaid <omair.javaid@linaro.org> writes:
>
> Omair> ARM assembler recognise @ symbol as a comment marker and therefore is
> Omair> unable to assemble some of gdb.dwarf2 testsuite tests. This patch
> Omair> replaces all occurrences of @ symbol with % sign to allow tests stay
> Omair> compatible with both arm and x86 assembly. This patch has been tested
> Omair> on x86_64 and armv7 targets.
>
> Omair> 2013-06-10 Omair Javaid <Omair.Javaid@linaro.org>
> Omair> * gdb.dwarf2/fission-reread.S: Replace @ sign with % sign to remove
> Omair> assembler errors on arm.
> Omair> * gdb.dwarf2/mac-fileno.S: Likewise
> Omair> * gdb.dwarf2/member-ptr-forwardref.S: Likewise
> Omair> * gdb.dwarf2/pr13961.S: Likewise
>
> This is ok. Thanks.
I committed this change on Omair's behalf.
--
Will Newton
Toolchain Working Group, Linaro