This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix up msymbol type of dll trampoline to mst_solib_trampoline
- From: Yao Qi <yao at codesourcery dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 18 Jul 2013 10:08:45 +0800
- Subject: Re: [PATCH] Fix up msymbol type of dll trampoline to mst_solib_trampoline
- References: <1372043502-4618-1-git-send-email-yao at codesourcery dot com> <874ncjmgkl dot fsf at fleche dot redhat dot com> <51CD0054 dot 9040401 at codesourcery dot com> <87ehbmkzqr dot fsf at fleche dot redhat dot com> <51D36FB3 dot 4070006 at codesourcery dot com> <87vc4igxq6 dot fsf at fleche dot redhat dot com>
On 07/11/2013 12:56 AM, Tom Tromey wrote:
This should use ALL_OBJFILE_MSYMBOLS.
I'm mildly concerned that this exposes an implementation detail of the
minsym storage -- namely, it assumes that it is ok to modify a minsym
after the minsym is installed.
Right, we had this assumption in this patch. If MSYMBOL_TYPE is used in
the computation of hash key, we can't do this after minsym is installed
(hashtab is set up).
This approach would also block constification of the minsym API.
Neither of these seem like blocking considerations though. Presumably
bugs arising from the first would be caught in testing; and for the
second, casting away const would be obviously ok.
So, ok with the ALL_OBJFILE_MSYMBOLS change.
Thanks for the review. Change to use ALL_OBJFILE_MSYMBOLS and
regression tested again. The fail is still fixed.
-FAIL: gdb.base/solib-symbol.exp: foo in libmd
+PASS: gdb.base/solib-symbol.exp: foo in libmd
Committed.
--
Yao (éå)